diff options
| author | Jiada Wang <jiada_wang@mentor.com> | 2019-04-24 14:11:45 +0900 |
|---|---|---|
| committer | Ryo Kataoka <ryo.kataoka.wt@renesas.com> | 2019-07-11 21:17:14 +0900 |
| commit | 1a76e02667ece64de603e392713215acc1c47ed4 (patch) | |
| tree | aee3b916f3ad1fadd09b04503b9f7e79e462fda3 | |
| parent | ce83585d886fe9e329492839bcff4fd06045634c (diff) | |
| download | renesas-bsp-1a76e02667ece64de603e392713215acc1c47ed4.tar.gz | |
thermal: rcar_gen3_thermal: disable interrupt in .remove
Currently IRQ remains enabled after .remove, later if device is probed,
IRQ is requested before .thermal_init, this may cause IRQ function be
called before device is initialized.
this patch disables interrupt in .remove, to ensure irq function
only be called after device is fully initialized.
Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
(cherry picked from commit 63f55fcea50c25ae5ad45af92d08dae3b84534c2)
Signed-off-by: The Kinh Nguyen <the.nguyen.vx@renesas.com>
| -rw-r--r-- | drivers/thermal/rcar_gen3_thermal.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c index ae17e73d770b96..7b51f966deff97 100644 --- a/drivers/thermal/rcar_gen3_thermal.c +++ b/drivers/thermal/rcar_gen3_thermal.c @@ -524,6 +524,9 @@ MODULE_DEVICE_TABLE(of, rcar_gen3_thermal_dt_ids); static int rcar_gen3_thermal_remove(struct platform_device *pdev) { struct device *dev = &pdev->dev; + struct rcar_gen3_thermal_priv *priv = dev_get_drvdata(dev); + + rcar_thermal_irq_set(priv, false); pm_runtime_put(dev); pm_runtime_disable(dev); |