aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTiwei Bie <tiwei.bie@intel.com>2019-07-31 09:34:46 +0800
committerMichael S. Tsirkin <mst@redhat.com>2019-09-08 17:17:56 -0400
commit6aecd69eb90bb1feb0c8badf6af7065e55b7a2e7 (patch)
treeacee890ac8c4b7ec95af997671becfe994f3c9ed
parent7a25d74962d39ec3192a998bbefaf21bb46b642e (diff)
downloadvirtio-text-6aecd69eb90bb1feb0c8badf6af7065e55b7a2e7.tar.gz
content: explicitly document the VLAN filtering as best-effort
Similar to the MAC address based filtering, the VLAN filtering is also best-effort in implementations, but it's not quite clear in the spec. So document this behaviour explicitly to reflect the way implementations behave. Signed-off-by: Tiwei Bie <tiwei.bie@intel.com> Acked-by: Michael S. Tsirkin <mst@redhat.com> Reviewed-by: Cornelia Huck <cohuck@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/47
-rw-r--r--content.tex5
1 files changed, 5 insertions, 0 deletions
diff --git a/content.tex b/content.tex
index 24a8927..37a2190 100644
--- a/content.tex
+++ b/content.tex
@@ -3609,6 +3609,11 @@ of \field{mac} in the config space.
If the driver negotiates the VIRTIO_NET_F_CTRL_VLAN feature, it
can control a VLAN filter table in the device.
+\begin{note}
+Similar to the MAC address based filtering, the VLAN filtering
+is also best-effort: unwanted packets could still arrive.
+\end{note}
+
\begin{lstlisting}
#define VIRTIO_NET_CTRL_VLAN 2
#define VIRTIO_NET_CTRL_VLAN_ADD 0