diff options
| author | Steven Rostedt (Google) <rostedt@goodmis.org> | 2024-01-24 12:49:27 -0500 |
|---|---|---|
| committer | Steven Rostedt (Google) <rostedt@goodmis.org> | 2024-01-24 12:58:42 -0500 |
| commit | 3b6096fc8d2865fae0deafc2723aec8c7742342e (patch) | |
| tree | 0daebd9aefbf467f29f4f740d1ab3f6f2a969300 | |
| parent | 1439b8f5189414b259905102da23446ba78db033 (diff) | |
| download | trace-cmd-3b6096fc8d2865fae0deafc2723aec8c7742342e.tar.gz | |
trace-cmd split: Initialize current in parse_file()
The code fix to correctly split start/end/time-window parameters removed
an initialization of "current" which can now fall out being uninitialized
and used for a later compare.
Found with valgrind.
Link: https://lore.kernel.org/linux-trace-devel/20240124122832.4e0b33b7@gandalf.local.home/
Link: https://lore.kernel.org/linux-trace-devel/20240124124927.3551e982@gandalf.local.home
Cc: Pierre Gondois <pierre.gondois@arm.com>
Fixes: 1439b8f518 ("trace-cmd split: Correctly split with start/end/time-window parameters")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
| -rw-r--r-- | tracecmd/trace-split.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tracecmd/trace-split.c b/tracecmd/trace-split.c index b6c056b5..8c710da1 100644 --- a/tracecmd/trace-split.c +++ b/tracecmd/trace-split.c @@ -358,7 +358,7 @@ static unsigned long long parse_file(struct tracecmd_input *handle, enum split_types type, bool *end_reached) { - unsigned long long current; + unsigned long long current = 0; struct tracecmd_output *ohandle; struct cpu_data *cpu_data; struct tep_record *record; |