aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYordan Karadzhov (VMware) <y.karadz@gmail.com>2020-12-09 15:45:23 +0200
committerSteven Rostedt (VMware) <rostedt@goodmis.org>2020-12-22 10:52:42 -0500
commite241833c34ed61175fd0f31c581a90d99c2abed2 (patch)
treeb6c45ee9a9bcdc85351e830e1df3f98dfedaf0ce
parent2bbf4339b73c3ad0e744cc73f8695ee58437d3ee (diff)
downloadkernel-shark-e241833c34ed61175fd0f31c581a90d99c2abed2.tar.gz
kernel-shark: Redefine the args of KsPlot::getColor()
The function was originally designed to return the color that correspond to a given PID. However we now have 3 different color maps (for PID, CPU Id and Stream Id) and the same method can be used with each of the 3 maps. We also want to prevent the method from modifying the map itself. Link: https://lore.kernel.org/linux-trace-devel/20201209134530.428368-4-y.karadz@gmail.com Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-rw-r--r--src/KsPlotTools.cpp10
-rw-r--r--src/KsPlotTools.hpp2
2 files changed, 6 insertions, 6 deletions
diff --git a/src/KsPlotTools.cpp b/src/KsPlotTools.cpp
index cfaec77d..ef15cde7 100644
--- a/src/KsPlotTools.cpp
+++ b/src/KsPlotTools.cpp
@@ -233,17 +233,17 @@ ColorTable getStreamColorTable()
}
/**
- * @brief Search the Hash table of Rainbow colors for a particular key (pid).
+ * @brief Search the Hash table of Rainbow colors for a particular key (Id).
*
* @param colors: Input location for the ColorTable instance.
- * @param pid: the Process Id to search for.
+ * @param id: The Id to search for.
*
- * @returns The Rainbow color of the key "pid". If "pid" does not exist, the
+ * @returns The Rainbow color of the key "id". If "id" does not exist, the
* returned color is Black.
*/
-Color getColor(ColorTable *colors, int pid)
+Color getColor(const ColorTable *colors, int id)
{
- auto item = colors->find(pid);
+ auto item = colors->find(id);
if (item != colors->end())
return item->second;
diff --git a/src/KsPlotTools.hpp b/src/KsPlotTools.hpp
index b64aaf5b..b270a564 100644
--- a/src/KsPlotTools.hpp
+++ b/src/KsPlotTools.hpp
@@ -82,7 +82,7 @@ ColorTable getCPUColorTable();
ColorTable getStreamColorTable();
-Color getColor(ColorTable *colors, int pid);
+Color getColor(const ColorTable *colors, int id);
/** Represents an abstract graphical element. */
class PlotObject {