diff options
| author | John Kacur <jkacur@redhat.com> | 2019-12-02 13:05:02 +0100 |
|---|---|---|
| committer | John Kacur <jkacur@redhat.com> | 2019-12-02 13:05:02 +0100 |
| commit | ba69dfd96da37208c63313ecab233a39568d576c (patch) | |
| tree | a1ef8549e09a37f24373400f5de6aaebdf538a82 | |
| parent | 21dbce7a7814d8e91a9a35408c2fb119e1b9a012 (diff) | |
| download | rteval-ba69dfd96da37208c63313ecab233a39568d576c.tar.gz | |
rteval: node in args to Popen must be a string
In hackbench.py, the args to Popen must be a string and not an integer
Before this change, this can happen.
rteval --duration=1m
got system topology: 2 node system (10 cores per node)
rteval run on 4.18.0-151.rt13.8.el8.x86_64 started at Tue Nov 26 14:42:18 2019
started 2 loads on 20 cores with 2 numa nodes
started measurement threads on 20 cores
Run duration: 60.0 seconds
Exception in thread hackbench:
Traceback (most recent call last):
File "/usr/lib64/python3.6/threading.py", line 916, in _bootstrap_inner
self.run()
File "/usr/lib/python3.6/site-packages/rteval/modules/__init__.py", line 188, in run
self._WorkloadTask()
File "/usr/lib/python3.6/site-packages/rteval/modules/loads/hackbench.py", line 147, in _WorkloadTask
self.tasks[n] = self.__starton(n)
File "/usr/lib/python3.6/site-packages/rteval/modules/loads/hackbench.py", line 134, in __starton
stderr=self.__err)
File "/usr/lib64/python3.6/subprocess.py", line 729, in __init__
restore_signals, start_new_session)
File "/usr/lib64/python3.6/subprocess.py", line 1295, in _execute_child
restore_signals, start_new_session, preexec_fn)
TypeError: expected str, bytes or os.PathLike object, not int
After converting the node to a string, it works as expected
Signed-off-by: John Kacur <jkacur@redhat.com>
| -rw-r--r-- | rteval/modules/loads/hackbench.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/rteval/modules/loads/hackbench.py b/rteval/modules/loads/hackbench.py index b15ea63..f31e29d 100644 --- a/rteval/modules/loads/hackbench.py +++ b/rteval/modules/loads/hackbench.py @@ -120,7 +120,7 @@ class Hackbench(CommandLineLoad): def __starton(self, node): if self.__multinodes or self.cpulist: if self.__usenumactl: - args = [ 'numactl', '--cpunodebind', node ] + self.args + args = [ 'numactl', '--cpunodebind', str(node) ] + self.args else: cpulist = ",".join([ str(n) for n in self.cpus[node] ]) args = ['taskset', '-c', cpulist ] + self.args |