diff options
| author | Crystal Wood <crwood@redhat.com> | 2024-03-04 15:16:55 -0600 |
|---|---|---|
| committer | John Kacur <jkacur@redhat.com> | 2024-04-02 16:52:04 -0400 |
| commit | 4dba4837a27b771c90d8f32aa0b22db7e6fac815 (patch) | |
| tree | 49002263ede94b3180dc766ccb2bbd85e2838071 | |
| parent | 5a506ad780603102c54ff30fe82b6b53415a6b11 (diff) | |
| download | rteval-4dba4837a27b771c90d8f32aa0b22db7e6fac815.tar.gz | |
rteval: Remove 30 second "settling" period
Waiting for 30 seconds for loads to "settle down" adds unneccesary delay
to very short runs, besides being a giant hack. Load modules already
have the opportunity to do setup beforehand.
Even if there are a few seconds before the loads get to their expected
"heaviness", that shouldn't meaningfully affect the output except for:
- very short runs where you either
- don't care about the latency because you're debugging rteval itself, or
- are debugging a latency that reliably shows quickly, in which case
consistent behavior is enough
- latency spikes that only show up during load startup activity, in
which case measuring it is a good thing
- minimum latency values, which are not really the point of rteval.
...and the 30 second delay is *especially* useless if loads are disabled.
Currently there's no official way to do that (as far as I can find), but
it can be done by disabling all but stressng in the conf file, and not
supplying stressng options on the command line.
Signed-off-by: Crystal Wood <crwood@redhat.com>
Signed-off-by: John Kacur <jkacur@redhat.com>
| -rw-r--r-- | rteval/__init__.py | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/rteval/__init__.py b/rteval/__init__.py index 927e8b9..1a61148 100644 --- a/rteval/__init__.py +++ b/rteval/__init__.py @@ -173,8 +173,6 @@ class RtEval(rtevalReport): nthreads = threading.active_count() else: nthreads = None - self.__logger.log(Log.INFO, "Waiting 30 seconds to let load modules settle down") - time.sleep(30) measure_profile.Unleash() measure_start = datetime.now() |