diff options
| author | Paul Barker <paul@pbarker.dev> | 2021-05-30 17:36:23 +0100 |
|---|---|---|
| committer | Konstantin Ryabitsev <konstantin.ryabitsev@linux.dev> | 2021-05-31 11:11:15 -0400 |
| commit | 1fc7ed529fc07036072b79c040f083b1db1c668a (patch) | |
| tree | 63eeaf810370ee3c97d84d5fc4d66e5e95371ad7 | |
| parent | 30840a6acae935ebc5332d08d61222cebe0b518b (diff) | |
| download | patatt-1fc7ed529fc07036072b79c040f083b1db1c668a.tar.gz | |
Make instructions for automatic signing more reliable
We can't assume that the git directory path is '.git' from the root of
the source tree. For example, this is not the correct path if patatt is
checked out as a git submodule. We should use `git rev-parse --git-dir`
to reliably determine the git directory path. We should also surround
the path in quotes in case the user has cloned patatt in a path
containing spaces.
Signed-off-by: Paul Barker <paul@pbarker.dev>
Signed-off-by: Konstantin Ryabitsev <konstantin.ryabitsev@linux.dev>
Link: https://lore.kernel.org/r/20210530163623.926-1-paul@pbarker.dev
| -rw-r--r-- | README.rst | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -184,8 +184,8 @@ Automatic signing via the sendemail-validate hook If everything is working well, you can start automatically signing all outgoing patches sent via git-send-email:: - $ echo 'patatt sign --hook "${1}"' > .git/hooks/sendemail-validate - $ chmod a+x .git/hooks/sendemail-validate + $ echo 'patatt sign --hook "${1}"' > "$(git rev-parse --git-dir)/hooks/sendemail-validate" + $ chmod a+x "$(git rev-parse --git-dir)/hooks/sendemail-validate" PGP vs ed25519 keys considerations ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |