Revert "kup-server: allow deployment with a 1777 tmp directory"

This reverts commit fc4e6164a0457d81f2f22357d251fce306f5e326.

This is the totally wrong way to do it, and actually harms security.

Signed-off-by: H. Peter Anvin <hpa@zytor.com>

1 files changed, 4 insertions, 11 deletions

diff --git a/kup-server b/kup-server
index 006dcdc..f020548 100755
--- a/kup-server
+++ b/kup-server
@@ -55,7 +55,7 @@ use IPC::Open2 qw(open2);
 
 use File::Temp qw(tempdir);
 use BSD::Resource;
-use Fcntl qw(:DEFAULT :flock :mode);
+use Fcntl qw(:DEFAULT :flock);
 use POSIX;
 
 use Sys::Syslog qw(:standard :macros);
@@ -148,16 +148,9 @@ sub make_temp_dir() {
     $template = $1.'-XXXXXXXXXXXX';
 
     umask(077);
-
-    # Create the per-user temp directory if it doesn't exist already
-    mkdir($root, 0700);
-    my @rs = lstat($root);
-    if (!S_ISDIR($rs[2]) || $rs[4] != getuid() || ($rs[2] & 07777) != 0700) {
-	fatal("Something is squatting on my temp directory!");
-    }
-
-    # Create the session directory
-    my $dir = tempdir($template, DIR => $root, CLEANUP => 1);
+    my $dir = tempdir($template,
+		      DIR => $tmp_path.'/'.$user_name,
+		      CLEANUP => 1);
 }
 
 my $tmpdir = make_temp_dir();