aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlan Jenkins <alan-jenkins@tuffmail.co.uk>2009-09-30 17:22:10 +0100
committerAlan Jenkins <alan-jenkins@tuffmail.co.uk>2010-02-25 15:29:24 +0000
commit4b4fb8c2e5a1f6f85c3e19c7183bc6e79852f5f7 (patch)
tree76b80f67cf7ce6f7b535b69918dfa6bdece79510
parent09e4ce22b5751918ea1c8bd11ee36a10bcc21c54 (diff)
downloadmodule-init-tools-4b4fb8c2e5a1f6f85c3e19c7183bc6e79852f5f7.tar.gz
modprobe: fix potential memory leak on failure path
Ensure release_elf_file() is called on a rare failure path. Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
-rw-r--r--modprobe.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/modprobe.c b/modprobe.c
index 1891dad..9f92ae2 100644
--- a/modprobe.c
+++ b/modprobe.c
@@ -1279,7 +1279,7 @@ static int insmod(struct list_head *list,
if (flags & mit_first_time)
error("Module %s already in kernel.\n",
newname ?: mod->modname);
- goto out_unlock;
+ goto out_elf_file;
}
/* don't warn noisely if we're loading multiple aliases. */
/* one of the aliases may try to use hardware we don't have. */