diff options
author | Vivek Goyal <vgoyal@in.ibm.com> | 2006-07-27 15:13:05 -0700 |
---|---|---|
committer | Eric W. Biederman <ebiederm@xmission.com> | 2006-07-28 13:05:13 -0600 |
commit | 2f2aa1af0325ee974ef2526cef1a2546a9923281 (patch) | |
tree | cd084ded16ca9a386e04c2e03afaeb79f60bb5f1 /purgatory | |
parent | b02d735bf252117b3c9f7d56b65072e64ce531c0 (diff) | |
download | kexec-tools-2f2aa1af0325ee974ef2526cef1a2546a9923281.tar.gz |
kexec-tools: i386 backup region naming convention fix
On Thu, Jul 27, 2006 at 12:32:56PM -0600, Eric W. Biederman wrote:
>
> I have found a couple of moments and have been able to
> catch up with most of the backlog of patches for kexec-tools.
> There are several details I need to follow up on, and there is
> some testing I want to do to make certain everything is working.
>
> The primary kexec-tools archive is:
> git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/kexec-tools.git
>
> An archive to hold versions before 1.101 is at:
> git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/kexec-tools-historic.git
>
> So far I have all version in there since 1.0 except 1.9, 1.92, and 1.93
> if someone happens to have a copy point me at it and I will update the
> history.
>
> Patches that hang out in quilt for a while can be annoying to import
> into git because their authorship information is not stored in an
> unambiguous way. git is general is much stricter about the format
> it's meta-data information is stored in.
>
> Maneesh in kdump10 there were two patches in particular that I have
> not sorted out their who wrote them. If you could help me sort that
> out I would appreciate it.
>
> ppc64-initrd-option.patch
> ppc64-kdump-device_tree-sort.patch
>
> Before I make a release here is my list of things I intend to look at:
> - Why we have defined the location of the crash backup region twice.
Hi Eric,
Are you referring to BACKUP_REGION_START and BACKUP_START declarations?
I am not sure why did I do that, may be somehow I thought that purgatory
code is not sharing the header files with main kexec code base.
Please have a look at the patch attached for i386. If this looks
fine, I shall generate the patches for x86_64 and ppc64 too.
Thanks & Regards
Vivek
Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com>
Diffstat (limited to 'purgatory')
-rw-r--r-- | purgatory/arch/i386/crashdump_backup.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/purgatory/arch/i386/crashdump_backup.c b/purgatory/arch/i386/crashdump_backup.c index 39a1946e..c6194460 100644 --- a/purgatory/arch/i386/crashdump_backup.c +++ b/purgatory/arch/i386/crashdump_backup.c @@ -20,9 +20,7 @@ #include <stdint.h> #include <string.h> - -#define BACKUP_REGION_SOURCE 0x00000000 -#define BACKUP_REGION_SIZE 0xa0000 +#include "../../../kexec/arch/i386/crashdump-x86.h" /* Backup region start gets set after /proc/iomem has been parsed. */ /* We reuse the same code for x86_64 also so changing backup_start to @@ -37,10 +35,10 @@ void crashdump_backup_memory(void) { void *dest, *src; - src = (void *) BACKUP_REGION_SOURCE; + src = (void *) BACKUP_SRC_START; if (backup_start) { dest = (void *)(backup_start); - memcpy(dest, src, BACKUP_REGION_SIZE); + memcpy(dest, src, BACKUP_SRC_SIZE); } } |