diff options
author | Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com> | 2013-02-08 15:58:10 +0200 |
---|---|---|
committer | Marcel Holtmann <marcel@holtmann.org> | 2013-02-23 11:51:20 +0100 |
commit | f9cd982756c396116346026f3b94122a677a8553 (patch) | |
tree | 5f53542e78827108291448b37220de8325dfbdf6 | |
parent | 7b1df8ec70de53501c33dd8c6eca0f792cccf26a (diff) | |
download | pacrunner-f9cd982756c396116346026f3b94122a677a8553.tar.gz |
gdbus: Always unreference the message in g_dbus_send_message()
A quick fix on g_dbus_send_message(), if check_signal() fails it returns
FALSE without unreferencing the message as it should. This patch fixes
it.
-rw-r--r-- | gdbus/object.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/gdbus/object.c b/gdbus/object.c index 43fb1f0..2f8ef45 100644 --- a/gdbus/object.c +++ b/gdbus/object.c @@ -1496,7 +1496,7 @@ DBusMessage *g_dbus_create_reply(DBusMessage *message, int type, ...) gboolean g_dbus_send_message(DBusConnection *connection, DBusMessage *message) { - dbus_bool_t result; + dbus_bool_t result = FALSE; if (dbus_message_get_type(message) == DBUS_MESSAGE_TYPE_METHOD_CALL) dbus_message_set_no_reply(message, TRUE); @@ -1507,11 +1507,12 @@ gboolean g_dbus_send_message(DBusConnection *connection, DBusMessage *message) const GDBusArgInfo *args; if (!check_signal(connection, path, interface, name, &args)) - return FALSE; + goto out; } result = dbus_connection_send(connection, message, NULL); +out: dbus_message_unref(message); return result; |