diff options
| author | Luiz Augusto von Dentz <luiz.von.dentz@intel.com> | 2013-08-19 16:54:35 +0300 |
|---|---|---|
| committer | Marcel Holtmann <marcel@holtmann.org> | 2013-09-10 19:05:16 -0700 |
| commit | 382fea0bc25ab6837f25f9bc0f491904be02c6d8 (patch) | |
| tree | b9dc04722b9a54611c153222936fa50a2d2acdd5 | |
| parent | 50647d61c7e5d595a2d2ad8bbfc1184df003612c (diff) | |
| download | pacrunner-382fea0bc25ab6837f25f9bc0f491904be02c6d8.tar.gz | |
gdbus: Fix emitting PropertiesChanged twice
This fixes double emission of PropertiesChanged introduced by flushing
changes, the flushing can happen during the pending processing so the
pending_prop flag needs to be updated in the beginning and the list of
properties can be freed before g_dbus_send_message as it is not required
anymore.
| -rw-r--r-- | gdbus/object.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gdbus/object.c b/gdbus/object.c index c4cf724..0822fe8 100644 --- a/gdbus/object.c +++ b/gdbus/object.c @@ -1642,6 +1642,8 @@ static void process_properties_from_interface(struct generic_data *data, DBusMessageIter iter, dict, array; GSList *invalidated; + data->pending_prop = FALSE; + if (iface->pending_prop == NULL) return; @@ -1708,8 +1710,6 @@ static void process_property_changes(struct generic_data *data) process_properties_from_interface(data, iface); } - - data->pending_prop = FALSE; } void g_dbus_emit_property_changed(DBusConnection *connection, |