aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArman Uguray <armansito@chromium.org>2015-02-27 00:16:24 -0800
committerMarcel Holtmann <marcel@holtmann.org>2015-03-26 10:03:20 +0100
commit18ea4aab08eb3bd5692c0ff159fa8e0da11eccea (patch)
treed0ace7809a86a712d7b4353dbc1241f5d77f8f92
parenta29d429ed3b790de3e730155df67a22d10880f19 (diff)
downloadpacrunner-18ea4aab08eb3bd5692c0ff159fa8e0da11eccea.tar.gz
gdbus/client: Don't GetManagedObjects w/o handlers
The client code currently issues GetManagedObjects if new handlers are set via g_dbus_client_set_proxy_handlers. An application may set these to NULL before unref'ing a client or to simply prevent further events. Hence, there is no need to refresh objects or properties if all handlers are NULL.
-rw-r--r--gdbus/client.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/gdbus/client.c b/gdbus/client.c
index 238b348..cd5c767 100644
--- a/gdbus/client.c
+++ b/gdbus/client.c
@@ -1374,7 +1374,8 @@ gboolean g_dbus_client_set_proxy_handlers(GDBusClient *client,
client->property_changed = property_changed;
client->user_data = user_data;
- get_managed_objects(client);
+ if (proxy_added || proxy_removed || property_changed)
+ get_managed_objects(client);
return TRUE;
}