diff options
| author | Eric Biggers <ebiggers@google.com> | 2016-11-30 14:31:42 -0800 |
|---|---|---|
| committer | Eryu Guan <eguan@redhat.com> | 2016-12-02 19:31:02 +0800 |
| commit | adcc60c6bf6aa10eb54309b712c1359bb4216eb4 (patch) | |
| tree | 63b103c23ffb387487efb25c46fdc1208600f661 | |
| parent | c3aba25afa87fb8adb1228a13068c2078d9157bc (diff) | |
| download | xfstests-dev-adcc60c6bf6aa10eb54309b712c1359bb4216eb4.tar.gz | |
build: allow building with latest xfslibs on 32-bit Linux
The next version of xfslibs will require that its users enable
transparent largefile support. This broke building xfstests on
32-bit Linux because _FILE_OFFSET_BITS=64 was not getting defined
when testing for xfs headers. Fix this by defining
_FILE_OFFSET_BITS=64 when doing configure checks for the xfs
headers.
It was not necessary to define _FILE_OFFSET_BITS=64 for the actual
build because it's already done, in builddefs.in.
The problem could also be solved by adding AC_SYS_LARGEFILE to
configure.ac. It's debatable, but I chose not to do that because it
might give the impression that it affects the actual compilation of
the test programs and not just the configure checks. (Since not all
.c files include config.h first, a _FILE_OFFSET_BITS definition in
config.h wouldn't always take effect.)
Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Eryu Guan <eguan@redhat.com>
Signed-off-by: Eryu Guan <eguan@redhat.com>
| -rw-r--r-- | m4/package_xfslibs.m4 | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/m4/package_xfslibs.m4 b/m4/package_xfslibs.m4 index 6bf47040d9..5588e9ed57 100644 --- a/m4/package_xfslibs.m4 +++ b/m4/package_xfslibs.m4 @@ -1,5 +1,8 @@ AC_DEFUN([AC_PACKAGE_NEED_XFS_XFS_H], - [ AC_CHECK_HEADERS([xfs/xfs.h],,,[#define _GNU_SOURCE]) + [ AC_CHECK_HEADERS([xfs/xfs.h],,,[ + #define _GNU_SOURCE + #define _FILE_OFFSET_BITS 64 + ]) if test "$ac_cv_header_xfs_xfs_h" != "yes"; then echo echo 'FATAL ERROR: cannot find a valid <xfs/xfs.h> header file.' @@ -23,7 +26,10 @@ AC_DEFUN([AC_PACKAGE_WANT_XLOG_ASSIGN_LSN], ]) AC_DEFUN([AC_PACKAGE_NEED_XFS_XQM_H], - [ AC_CHECK_HEADERS([xfs/xqm.h],,,[#define _GNU_SOURCE]) + [ AC_CHECK_HEADERS([xfs/xqm.h],,,[ + #define _GNU_SOURCE + #define _FILE_OFFSET_BITS 64 + ]) if test "$ac_cv_header_xfs_xqm_h" != "yes"; then echo echo 'FATAL ERROR: cannot find a valid <xfs/xqm.h> header file.' @@ -103,6 +109,7 @@ AC_DEFUN([AC_PACKAGE_NEED_XFSCTL_MACRO], [ AC_MSG_CHECKING([xfsctl from xfs/xfs.h]) AC_TRY_LINK([ #define _GNU_SOURCE +#define _FILE_OFFSET_BITS 64 #include <xfs/xfs.h> ], [ int x = xfsctl(0, 0, 0, 0); ], [ echo ok ], |