diff options
| author | Anand Jain <anand.jain@oracle.com> | 2021-10-05 16:12:39 -0400 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2021-10-26 19:08:06 +0200 |
| commit | 8e906945c069fbc9377f2748a661ac06d039ea77 (patch) | |
| tree | e41d6cc6164117fc9f0424362941d63229826bca /fs | |
| parent | 10adb1152d957a4d570ad630f93a88bb961616c1 (diff) | |
| download | linux-8e906945c069fbc9377f2748a661ac06d039ea77.tar.gz | |
btrfs: use num_device to check for the last surviving seed device
For both sprout and seed fsids,
btrfs_fs_devices::num_devices provides device count including missing
btrfs_fs_devices::open_devices provides device count excluding missing
We create a dummy struct btrfs_device for the missing device, so
num_devices != open_devices when there is a missing device.
In btrfs_rm_devices() we wrongly check for %cur_devices->open_devices
before freeing the seed fs_devices. Instead we should check for
%cur_devices->num_devices.
Signed-off-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/btrfs/volumes.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 6031e2f4c6bc39..0941f61d807105 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -2211,7 +2211,7 @@ int btrfs_rm_device(struct btrfs_fs_info *fs_info, const char *device_path, synchronize_rcu(); btrfs_free_device(device); - if (cur_devices->open_devices == 0) { + if (cur_devices->num_devices == 0) { list_del_init(&cur_devices->seed_list); close_fs_devices(cur_devices); free_fs_devices(cur_devices); |