diff options
| author | Steven Rostedt (VMware) <rostedt@goodmis.org> | 2019-07-22 11:37:07 -0400 |
|---|---|---|
| committer | Steven Rostedt (VMware) <rostedt@goodmis.org> | 2019-07-23 09:08:51 -0400 |
| commit | 00034f92c6df10876082e387347911817baeb69f (patch) | |
| tree | d403c53b2c868e7bc434e427200502b3738b601b | |
| parent | 11d683a8aaabc15a43bd084fb7ddac8d427e2ba4 (diff) | |
| download | trace-cmd-00034f92c6df10876082e387347911817baeb69f.tar.gz | |
kernel-shark: Add quotes around $XDG_SESSION_TYPE in kshark-su-record
If XDG_SESSION_TYPE is not set, then $XDG_SESSION_TYPE will become nothing,
which means the test:
if [ $XDG_SESSION_TYPE = "wayland" ];
turns into
if [ = "wayland" ];
And will cause a shell error. Adding quotes around "$XDG_SESSION_TYPE"
changes an empty $XDG_SESSION_TYPE into:
if [ "" = "wayland" ];
which the shell can understand.
Link: http://lore.kernel.org/linux-trace-devel/20190722113707.156a099f@gandalf.local.home
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=204261
Fixes: 9b1208c4e ("kernel-shark-qt: Workaround for running as Root on Wayland")
Reviewed-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
| -rwxr-xr-x | kernel-shark/bin/kshark-su-record | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel-shark/bin/kshark-su-record b/kernel-shark/bin/kshark-su-record index ee839a26..2477045f 100755 --- a/kernel-shark/bin/kshark-su-record +++ b/kernel-shark/bin/kshark-su-record @@ -1,6 +1,6 @@ #!/bin/bash -if [ $XDG_SESSION_TYPE = "wayland" ] +if [ "$XDG_SESSION_TYPE" = "wayland" ] then xhost +si:localuser:root &>/dev/null fi |