diff options
| author | Vasiliy Kulikov <segooon@gmail.com> | 2010-10-30 18:22:49 +0400 |
|---|---|---|
| committer | Willy Tarreau <w@1wt.eu> | 2010-12-18 14:57:57 +0100 |
| commit | 6f2d4be16ba60df10a42fb4d072d7bdd35aee4ae (patch) | |
| tree | 3602402a5b9a79e1cf7beed77a1d0e03b9f1b995 | |
| parent | 97aa7be6ee17a0966e8b8269e8c7b553134a2d82 (diff) | |
| download | linux-2.4-6f2d4be16ba60df10a42fb4d072d7bdd35aee4ae.tar.gz | |
ipc: shm: fix information leak to userland
The shmid_ds structure is copied to userland with shm_unused{,2,3}
fields unitialized. It leads to leaking of contents of kernel stack
memory.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Acked-by: Al Viro <viro@ZenIV.linux.org.uk>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
(cherry picked from commit 3af54c9bd9e6f14f896aac1bb0e8405ae0bc7a44)
Signed-off-by: Willy Tarreau <w@1wt.eu>
| -rw-r--r-- | ipc/shm.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/ipc/shm.c b/ipc/shm.c index 36cb09a37a612c..e9516e238c05aa 100644 --- a/ipc/shm.c +++ b/ipc/shm.c @@ -268,6 +268,7 @@ static inline unsigned long copy_shmid_to_user(void *buf, struct shmid64_ds *in, { struct shmid_ds out; + memset(&out, 0, sizeof(out)); ipc64_perm_to_ipc_perm(&in->shm_perm, &out.shm_perm); out.shm_segsz = in->shm_segsz; out.shm_atime = in->shm_atime; |