aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEric Dumazet <eric.dumazet@gmail.com>2009-09-02 02:40:09 +0000
committerWilly Tarreau <w@1wt.eu>2009-09-07 06:49:19 +0200
commit096ed17f20affc2db0e307658c69b67433992a7a (patch)
tree6c3da6e1cbc30fcd4fecb3f990fbb69fabe27e3b
parent30e744716c4a6cc4e8ecaaddf68f20057c03dc8d (diff)
downloadlinux-2.4-096ed17f20affc2db0e307658c69b67433992a7a.tar.gz
tc: Fix unitialized kernel memory leak
(backported from 2.6 commit 16ebb5e0b36ceadc8186f71d68b0c4fa4b6e781b) Three bytes of uninitialized kernel memory are currently leaked to user Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Reviewed-by: Jiri Pirko <jpirko@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Willy Tarreau <w@1wt.eu>
-rw-r--r--net/sched/sch_api.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
index 466007e553596c..6e07e539bbfde0 100644
--- a/net/sched/sch_api.c
+++ b/net/sched/sch_api.c
@@ -968,6 +968,8 @@ static int tc_fill_tclass(struct sk_buff *skb, struct Qdisc *q,
nlh->nlmsg_flags = flags;
tcm = NLMSG_DATA(nlh);
tcm->tcm_family = AF_UNSPEC;
+ tcm->tcm__pad1 = 0;
+ tcm->tcm__pad2 = 0;
tcm->tcm_ifindex = q->dev ? q->dev->ifindex : 0;
tcm->tcm_parent = q->handle;
tcm->tcm_handle = q->handle;