diff options
| author | Jiasheng Jiang <jiasheng@iscas.ac.cn> | 2021-12-20 22:03:44 +0800 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2021-12-22 12:25:18 -0800 |
| commit | 9b8bdd1eb5890aeeab7391dddcf8bd51f7b07216 (patch) | |
| tree | 0b063cc6873190434bf56a1e0602b2b21b9852b3 | |
| parent | bdf1b5c3884f6a0dc91b0dbdb8c3b7d205f449e0 (diff) | |
| download | slab-9b8bdd1eb5890aeeab7391dddcf8bd51f7b07216.tar.gz | |
sfc: falcon: Check null pointer of rx_queue->page_ring
Because of the possible failure of the kcalloc, it should be better to
set rx_queue->page_ptr_mask to 0 when it happens in order to maintain
the consistency.
Fixes: 5a6681e22c14 ("sfc: separate out SFC4000 ("Falcon") support into new sfc-falcon driver")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Acked-by: Martin Habets <habetsm.xilinx@gmail.com>
Link: https://lore.kernel.org/r/20211220140344.978408-1-jiasheng@iscas.ac.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | drivers/net/ethernet/sfc/falcon/rx.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/net/ethernet/sfc/falcon/rx.c b/drivers/net/ethernet/sfc/falcon/rx.c index 966f13e7475ddb..11a6aee852e92e 100644 --- a/drivers/net/ethernet/sfc/falcon/rx.c +++ b/drivers/net/ethernet/sfc/falcon/rx.c @@ -728,7 +728,10 @@ static void ef4_init_rx_recycle_ring(struct ef4_nic *efx, efx->rx_bufs_per_page); rx_queue->page_ring = kcalloc(page_ring_size, sizeof(*rx_queue->page_ring), GFP_KERNEL); - rx_queue->page_ptr_mask = page_ring_size - 1; + if (!rx_queue->page_ring) + rx_queue->page_ptr_mask = 0; + else + rx_queue->page_ptr_mask = page_ring_size - 1; } void ef4_init_rx_queue(struct ef4_rx_queue *rx_queue) |