diff options
| author | Kory Maincent <kory.maincent@bootlin.com> | 2024-03-12 10:16:38 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2024-03-12 13:55:57 +0000 |
| commit | e4ead3cdfd798092288f3a06b405cf98ded6fa10 (patch) | |
| tree | 456fc66eb1e16b2d8b879cdcb2d7d342b29076d8 | |
| parent | e6f0b08a036734552628ab788ecb528ca53814ab (diff) | |
| download | linux-e4ead3cdfd798092288f3a06b405cf98ded6fa10.tar.gz | |
regulator: core: Propagate the regulator state in case of exclusive get
Previously, performing an exclusive get on an already-enabled regulator
resulted in inconsistent state initialization between child and parent
regulators. While the child's counts were updated, its parent's counters
remained unaffected.
Consequently, attempting to disable an already-enabled exclusive regulator
triggered unbalanced disables warnings from its parent regulator.
This commit addresses the issue by propagating the enable state to the
parent regulator using a regulator_enable call. This ensures consistent
state management across the regulator hierarchy, preventing warnings!
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
Link: https://msgid.link/r/20240312091638.1266167-1-kory.maincent@bootlin.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/regulator/core.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index d019ca6dee9bff..dabac9772741fa 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -2274,6 +2274,17 @@ struct regulator *_regulator_get(struct device *dev, const char *id, if (ret > 0) { rdev->use_count = 1; regulator->enable_count = 1; + + /* Propagate the regulator state to its supply */ + if (rdev->supply) { + ret = regulator_enable(rdev->supply); + if (ret < 0) { + destroy_regulator(regulator); + module_put(rdev->owner); + put_device(&rdev->dev); + return ERR_PTR(ret); + } + } } else { rdev->use_count = 0; regulator->enable_count = 0; |