diff options
| author | Filipe Manana <fdmanana@suse.com> | 2024-03-13 11:37:31 +0000 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2024-03-26 16:42:38 +0100 |
| commit | 8a565ec04d6c43f330e7401e5af3458431b29bc6 (patch) | |
| tree | 68cb88d5775a2fe58fac733df0c425fa877c12f7 | |
| parent | 9f7eb8405dcbc79c5434821e9e3e92abe187ee8e (diff) | |
| download | linux-8a565ec04d6c43f330e7401e5af3458431b29bc6.tar.gz | |
btrfs: fix extent map leak in unexpected scenario at unpin_extent_cache()
At unpin_extent_cache() if we happen to find an extent map with an
unexpected start offset, we jump to the 'out' label and never release the
reference we added to the extent map through the call to
lookup_extent_mapping(), therefore resulting in a leak. So fix this by
moving the free_extent_map() under the 'out' label.
Fixes: c03c89f821e5 ("btrfs: handle errors returned from unpin_extent_cache()")
Reviewed-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
| -rw-r--r-- | fs/btrfs/extent_map.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/extent_map.c b/fs/btrfs/extent_map.c index 347ca13d15a975..e03953dbcd5ef5 100644 --- a/fs/btrfs/extent_map.c +++ b/fs/btrfs/extent_map.c @@ -340,9 +340,9 @@ int unpin_extent_cache(struct btrfs_inode *inode, u64 start, u64 len, u64 gen) em->mod_len = em->len; } - free_extent_map(em); out: write_unlock(&tree->lock); + free_extent_map(em); return ret; } |