diff options
| author | Zhipeng Lu <alexious@zju.edu.cn> | 2023-12-25 19:29:14 +0800 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2024-01-02 16:08:11 -0800 |
| commit | d5a306aedba34e640b11d7026dbbafb78ee3a5f6 (patch) | |
| tree | 331800f83760f6116aabac2f38a510cb0d60c4c5 | |
| parent | 8cdafdd94654ba418648d039c48e7a90508c1982 (diff) | |
| download | misc-d5a306aedba34e640b11d7026dbbafb78ee3a5f6.tar.gz | |
sfc: fix a double-free bug in efx_probe_filters
In efx_probe_filters, the channel->rps_flow_id is freed in a
efx_for_each_channel marco when success equals to 0.
However, after the following call chain:
ef100_net_open
|-> efx_probe_filters
|-> ef100_net_stop
|-> efx_remove_filters
The channel->rps_flow_id is freed again in the efx_for_each_channel of
efx_remove_filters, triggering a double-free bug.
Fixes: a9dc3d5612ce ("sfc_ef100: RX filter table management and related gubbins")
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Edward Cree <ecree.xilinx@gmail.com>
Signed-off-by: Zhipeng Lu <alexious@zju.edu.cn>
Link: https://lore.kernel.org/r/20231225112915.3544581-1-alexious@zju.edu.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | drivers/net/ethernet/sfc/rx_common.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/ethernet/sfc/rx_common.c b/drivers/net/ethernet/sfc/rx_common.c index d2f35ee15effeb..fac227d372db4c 100644 --- a/drivers/net/ethernet/sfc/rx_common.c +++ b/drivers/net/ethernet/sfc/rx_common.c @@ -823,8 +823,10 @@ int efx_probe_filters(struct efx_nic *efx) } if (!success) { - efx_for_each_channel(channel, efx) + efx_for_each_channel(channel, efx) { kfree(channel->rps_flow_id); + channel->rps_flow_id = NULL; + } efx->type->filter_table_remove(efx); rc = -ENOMEM; goto out_unlock; |