diff options
| author | David Gibson <david@gibson.dropbear.id.au> | 2010-08-30 12:53:03 +1000 |
|---|---|---|
| committer | Jon Loeliger <jdl@jdl.com> | 2010-09-20 09:32:21 -0500 |
| commit | 390635762d97502bda9c295fcb61b45d04d3d8d2 (patch) | |
| tree | 54b729b0f9355d72f5a65dd2d22ce9b29047c28c | |
| parent | 0e89e8c5a02eab5655f21e732c8f2ff145712ba8 (diff) | |
| download | dtc-390635762d97502bda9c295fcb61b45d04d3d8d2.tar.gz | |
Remove another bashism from run_tests.sh
Current we check for various error codes with [ $x == "NN" ]. However
'==' is not actually a correct operator for the [ (test) command. It
should be either '=' for string comparison or '-eq' for integer
comparison. It appears that the bash builtin version of test
implements '==' though, so we were getting away with it, as long as
/bin/sh was bash - or the testsuite generated no errors.
This patch fixes the usage of test so that it should work on non-bash
shells.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
| -rwxr-xr-x | tests/run_tests.sh | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/tests/run_tests.sh b/tests/run_tests.sh index 4cec62c..c2c39b6 100755 --- a/tests/run_tests.sh +++ b/tests/run_tests.sh @@ -24,11 +24,11 @@ base_run_test() { tot_pass=$((tot_pass + 1)) else ret="$?" - if [ "$ret" == "1" ]; then + if [ "$ret" -eq 1 ]; then tot_config=$((tot_config + 1)) - elif [ "$ret" == "2" ]; then + elif [ "$ret" -eq 2 ]; then tot_fail=$((tot_fail + 1)) - elif [ "$ret" == "$VGCODE" ]; then + elif [ "$ret" -eq $VGCODE ]; then tot_vg=$((tot_vg + 1)) else tot_strange=$((tot_strange + 1)) |