diff options
| author | Namjae Jeon <linkinjeon@kernel.org> | 2024-03-16 23:36:36 +0900 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2024-03-17 12:09:01 -0500 |
| commit | a80a486d72e20bd12c335bcd38b6e6f19356b0aa (patch) | |
| tree | e4f507cfd3dc0ba1cd0e469634187a71f4ee7f45 /fs | |
| parent | e758fa6956cbc873e4819ec3dd97cfd05a4c147e (diff) | |
| download | linux-kselftest-a80a486d72e20bd12c335bcd38b6e6f19356b0aa.tar.gz | |
ksmbd: fix slab-out-of-bounds in smb_strndup_from_utf16()
If ->NameOffset of smb2_create_req is smaller than Buffer offset of
smb2_create_req, slab-out-of-bounds read can happen from smb2_open.
This patch set the minimum value of the name offset to the buffer offset
to validate name length of smb2_create_req().
Cc: stable@vger.kernel.org
Reported-by: Xuanzhe Yu <yuxuanzhe@outlook.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/smb/server/smb2misc.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/fs/smb/server/smb2misc.c b/fs/smb/server/smb2misc.c index 03dded29a98042..7c872ffb4b0a98 100644 --- a/fs/smb/server/smb2misc.c +++ b/fs/smb/server/smb2misc.c @@ -107,7 +107,10 @@ static int smb2_get_data_area_len(unsigned int *off, unsigned int *len, case SMB2_CREATE: { unsigned short int name_off = - le16_to_cpu(((struct smb2_create_req *)hdr)->NameOffset); + max_t(unsigned short int, + le16_to_cpu(((struct smb2_create_req *)hdr)->NameOffset), + offsetof(struct smb2_create_req, Buffer)); + unsigned short int name_len = le16_to_cpu(((struct smb2_create_req *)hdr)->NameLength); |