diff options
| author | Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> | 2020-05-01 00:35:50 +0530 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-05-05 16:56:41 +0200 |
| commit | 115f32512f13c0280161908e9de45a97a87673bb (patch) | |
| tree | fbb7749662968c261a6cd939e2a3fac81e23d9b9 | |
| parent | d76bc8200f9cf8b6746e66b37317ba477eda25c4 (diff) | |
| download | printk-115f32512f13c0280161908e9de45a97a87673bb.tar.gz | |
bus: mhi: Fix parsing of mhi_flags
With the current parsing of mhi_flags, the following statement always
return false:
eob = !!(flags & MHI_EOB);
This is due to the fact that 'enum mhi_flags' starts with index 0 and we
are using direct AND operation to extract each bit. Fix this by using
BIT() macros for defining the flags so that the reset of the code need not
be touched.
Fixes: 189ff97cca53 ("bus: mhi: core: Add support for data transfer")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/20200430190555.32741-2-manivannan.sadhasivam@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | include/linux/mhi.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/include/linux/mhi.h b/include/linux/mhi.h index ad19960019653f..5642806360f3e8 100644 --- a/include/linux/mhi.h +++ b/include/linux/mhi.h @@ -53,9 +53,9 @@ enum mhi_callback { * @MHI_CHAIN: Linked transfer */ enum mhi_flags { - MHI_EOB, - MHI_EOT, - MHI_CHAIN, + MHI_EOB = BIT(0), + MHI_EOT = BIT(1), + MHI_CHAIN = BIT(2), }; /** |