diff options
| author | Darrick J. Wong <darrick.wong@oracle.com> | 2019-12-12 19:54:33 -0500 |
|---|---|---|
| committer | Eric Sandeen <sandeen@redhat.com> | 2019-12-12 19:54:33 -0500 |
| commit | 60a802ccc8fcc4b7480ab7ce8c4ce7b4a0caa205 (patch) | |
| tree | 0a197381615f5dc7341d2570beec6dee90f50563 | |
| parent | 5965a48272d3eedf68cc95ebc77f4e500837ee49 (diff) | |
| download | xfsprogs-dev-60a802ccc8fcc4b7480ab7ce8c4ce7b4a0caa205.tar.gz | |
xfs: remove unnecessary int returns from deferred bmap functions
Source kernel commit: 3e08f42ae7828bac2e7445a950f5de2b08203352
Remove the return value from the functions that schedule deferred bmap
operations since they never fail and do not return status.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
| -rw-r--r-- | libxfs/xfs_bmap.c | 12 | ||||
| -rw-r--r-- | libxfs/xfs_bmap.h | 4 |
2 files changed, 8 insertions, 8 deletions
diff --git a/libxfs/xfs_bmap.c b/libxfs/xfs_bmap.c index 470be877b9..7575e07ca9 100644 --- a/libxfs/xfs_bmap.c +++ b/libxfs/xfs_bmap.c @@ -6078,29 +6078,29 @@ __xfs_bmap_add( } /* Map an extent into a file. */ -int +void xfs_bmap_map_extent( struct xfs_trans *tp, struct xfs_inode *ip, struct xfs_bmbt_irec *PREV) { if (!xfs_bmap_is_update_needed(PREV)) - return 0; + return; - return __xfs_bmap_add(tp, XFS_BMAP_MAP, ip, XFS_DATA_FORK, PREV); + __xfs_bmap_add(tp, XFS_BMAP_MAP, ip, XFS_DATA_FORK, PREV); } /* Unmap an extent out of a file. */ -int +void xfs_bmap_unmap_extent( struct xfs_trans *tp, struct xfs_inode *ip, struct xfs_bmbt_irec *PREV) { if (!xfs_bmap_is_update_needed(PREV)) - return 0; + return; - return __xfs_bmap_add(tp, XFS_BMAP_UNMAP, ip, XFS_DATA_FORK, PREV); + __xfs_bmap_add(tp, XFS_BMAP_UNMAP, ip, XFS_DATA_FORK, PREV); } /* diff --git a/libxfs/xfs_bmap.h b/libxfs/xfs_bmap.h index 8f597f9abd..c409871a09 100644 --- a/libxfs/xfs_bmap.h +++ b/libxfs/xfs_bmap.h @@ -254,9 +254,9 @@ int xfs_bmap_finish_one(struct xfs_trans *tp, struct xfs_inode *ip, enum xfs_bmap_intent_type type, int whichfork, xfs_fileoff_t startoff, xfs_fsblock_t startblock, xfs_filblks_t *blockcount, xfs_exntst_t state); -int xfs_bmap_map_extent(struct xfs_trans *tp, struct xfs_inode *ip, +void xfs_bmap_map_extent(struct xfs_trans *tp, struct xfs_inode *ip, struct xfs_bmbt_irec *imap); -int xfs_bmap_unmap_extent(struct xfs_trans *tp, struct xfs_inode *ip, +void xfs_bmap_unmap_extent(struct xfs_trans *tp, struct xfs_inode *ip, struct xfs_bmbt_irec *imap); static inline int xfs_bmap_fork_to_state(int whichfork) |