diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2024-03-08 09:51:07 +0100 |
|---|---|---|
| committer | Dipen Patel <dipenp@nvidia.com> | 2024-04-12 11:02:58 -0700 |
| commit | 297f26dbf870d4f19591b74a0ab535c327917b81 (patch) | |
| tree | f842f826542cfe8cb02774b1316c17001b8e4c2c | |
| parent | 4cece764965020c22cff7665b18a012006359095 (diff) | |
| download | linux-for-next.tar.gz | |
hte: tegra-194: Convert to platform remove callback returning voidfor-6.10-rc1for-next
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Thierry Reding <treding@nvidia.com>
Acked-by: Dipen Patel <dipenp@nvidia.com>
Signed-off-by: Dipen Patel <dipenp@nvidia.com>
| -rw-r--r-- | drivers/hte/hte-tegra194-test.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/hte/hte-tegra194-test.c b/drivers/hte/hte-tegra194-test.c index ab2edff018eb68..8ee038ccf601dc 100644 --- a/drivers/hte/hte-tegra194-test.c +++ b/drivers/hte/hte-tegra194-test.c @@ -214,7 +214,7 @@ out: return ret; } -static int tegra_hte_test_remove(struct platform_device *pdev) +static void tegra_hte_test_remove(struct platform_device *pdev) { (void)pdev; @@ -222,13 +222,11 @@ static int tegra_hte_test_remove(struct platform_device *pdev) gpiod_put(hte.gpio_in); gpiod_put(hte.gpio_out); del_timer_sync(&hte.timer); - - return 0; } static struct platform_driver tegra_hte_test_driver = { .probe = tegra_hte_test_probe, - .remove = tegra_hte_test_remove, + .remove_new = tegra_hte_test_remove, .driver = { .name = "tegra_hte_test", .of_match_table = tegra_hte_test_of_match, |