aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlvin Šipraga <alsi@bang-olufsen.dk>2022-04-12 17:57:49 +0200
committerDavid S. Miller <davem@davemloft.net>2022-04-13 14:40:59 +0100
commit8e925de60ddaeccb455f0bdad17ce9d8cc2db2e1 (patch)
tree3733c380cf501d8a59da3f669ee1560138acc72d
parent2511e0c87786f333c4665508f421ac99e378c719 (diff)
downloadnet-next-8e925de60ddaeccb455f0bdad17ce9d8cc2db2e1.tar.gz
net: dsa: realtek: don't parse compatible string for RTL8366S
This switch is not even supported, but if someone were to actually put this compatible string "realtek,rtl8366s" in their device tree, they would be greeted with a kernel panic because the probe function would dereference NULL. So let's just remove it. Link: https://lore.kernel.org/all/CACRpkdYdKZs0WExXc3=0yPNOwP+oOV60HRz7SRoGjZvYHaT=1g@mail.gmail.com/ Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/dsa/realtek/realtek-smi.c5
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/net/dsa/realtek/realtek-smi.c b/drivers/net/dsa/realtek/realtek-smi.c
index 2243d3da55b29c..6cec559c90ceb9 100644
--- a/drivers/net/dsa/realtek/realtek-smi.c
+++ b/drivers/net/dsa/realtek/realtek-smi.c
@@ -546,11 +546,6 @@ static const struct of_device_id realtek_smi_of_match[] = {
.data = &rtl8366rb_variant,
},
#endif
- {
- /* FIXME: add support for RTL8366S and more */
- .compatible = "realtek,rtl8366s",
- .data = NULL,
- },
#if IS_ENABLED(CONFIG_NET_DSA_REALTEK_RTL8365MB)
{
.compatible = "realtek,rtl8365mb",