diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2012-05-17 10:08:14 +0300 |
|---|---|---|
| committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2012-05-17 00:29:02 -0700 |
| commit | 85938596a851ffe8c8784e291113fc3397c26c30 (patch) | |
| tree | 9b37721506b794fba242d1a6c0fbcdc29c2f7c34 | |
| parent | 929bdecb6b8fdfbc4f54e3d074177c08a92549d2 (diff) | |
| download | lio-core-85938596a851ffe8c8784e291113fc3397c26c30.tar.gz | |
iscsi-target: remove some dead code
Neither "acceptor_values" nor "proposer_values" can be NULL here.
Smatch complains because we are not allowed to pass NULL pointers to
strchr().
Also I removed a second later check for "!acceptor_values" because it
gets checked on the next line in the do while condition.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
| -rw-r--r-- | drivers/target/iscsi/iscsi_target_parameters.c | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/drivers/target/iscsi/iscsi_target_parameters.c b/drivers/target/iscsi/iscsi_target_parameters.c index ad3b3c1605d856..ed5241e7f12a1c 100644 --- a/drivers/target/iscsi/iscsi_target_parameters.c +++ b/drivers/target/iscsi/iscsi_target_parameters.c @@ -1037,13 +1037,6 @@ static char *iscsi_check_valuelist_for_support( tmp2 = strchr(acceptor_values, ','); if (tmp2) *tmp2 = '\0'; - if (!acceptor_values || !proposer_values) { - if (tmp1) - *tmp1 = ','; - if (tmp2) - *tmp2 = ','; - return NULL; - } if (!strcmp(acceptor_values, proposer_values)) { if (tmp2) *tmp2 = ','; @@ -1053,8 +1046,6 @@ static char *iscsi_check_valuelist_for_support( *tmp2++ = ','; acceptor_values = tmp2; - if (!acceptor_values) - break; } while (acceptor_values); if (tmp1) *tmp1++ = ','; |