aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlan Stern <stern@rowland.harvard.edu>2015-01-16 11:32:51 -0500
committerFelipe Balbi <balbi@ti.com>2015-08-03 09:54:18 -0500
commitc93e64e91248becd0edb8f01723dff9da890e2ab (patch)
tree9a1cf171d28a42d5fd4c2dd1e311d01e8c8998cf
parent4248bd7d3e2c7c87ff695d812018b8c22b5a5ab1 (diff)
downloadextcon-c93e64e91248becd0edb8f01723dff9da890e2ab.tar.gz
usb: udc: core: add device_del() call to error pathway
This patch fixes a bug in the error pathway of usb_add_gadget_udc_release() in udc-core.c. If the udc registration fails, the gadget registration is not fully undone; there's a put_device(&gadget->dev) call but no device_del(). CC: <stable@vger.kernel.org> Acked-by: Peter Chen <peter.chen@freescale.com> Signed-off-by: Alan Stern <stern@rowland.harvard.edu> Signed-off-by: Felipe Balbi <balbi@ti.com>
-rw-r--r--drivers/usb/gadget/udc/udc-core.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/usb/gadget/udc/udc-core.c b/drivers/usb/gadget/udc/udc-core.c
index 362ee8af5fce87..89ed5e71a1991e 100644
--- a/drivers/usb/gadget/udc/udc-core.c
+++ b/drivers/usb/gadget/udc/udc-core.c
@@ -323,6 +323,7 @@ err4:
err3:
put_device(&udc->dev);
+ device_del(&gadget->dev);
err2:
put_device(&gadget->dev);