diff options
| author | Chris Mi <cmi@nvidia.com> | 2020-12-08 10:48:35 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-12-09 16:08:33 -0800 |
| commit | 5137d303659d8c324e67814b1cc2e1bc0c0d9836 (patch) | |
| tree | d47fce9d7dae20e3156ee50ac35dd5a37739ebd5 | |
| parent | 8ef44b6fe49d2b8d03ba9aa69063612b474f963b (diff) | |
| download | linux-fullhistory-5137d303659d8c324e67814b1cc2e1bc0c0d9836.tar.gz | |
net: flow_offload: Fix memory leak for indirect flow block
The offending commit introduces a cleanup callback that is invoked
when the driver module is removed to clean up the tunnel device
flow block. But it returns on the first iteration of the for loop.
The remaining indirect flow blocks will never be freed.
Fixes: 1fac52da5942 ("net: flow_offload: consolidate indirect flow_block infrastructure")
CC: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Chris Mi <cmi@nvidia.com>
Reviewed-by: Roi Dayan <roid@nvidia.com>
| -rw-r--r-- | net/core/flow_offload.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/net/core/flow_offload.c b/net/core/flow_offload.c index d4474c812b6420..715b67f6c62f31 100644 --- a/net/core/flow_offload.c +++ b/net/core/flow_offload.c @@ -381,10 +381,8 @@ static void __flow_block_indr_cleanup(void (*release)(void *cb_priv), list_for_each_entry_safe(this, next, &flow_block_indr_list, indr.list) { if (this->release == release && - this->indr.cb_priv == cb_priv) { + this->indr.cb_priv == cb_priv) list_move(&this->indr.list, cleanup_list); - return; - } } } |