aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMaciej Żenczykowski <maze@google.com>2019-10-17 11:21:21 -0700
committerJohn W. Linville <linville@tuxdriver.com>2019-10-29 13:51:21 -0400
commit2941970e0f60fc90b0ef09f20f7fe9a72ab2dc1c (patch)
treeb628e2b1e40dc594f64c3177068745913ce853cb
parent5e814f2cc25df3bd4ffb892b92d0cb450faf9553 (diff)
downloadethtool-2941970e0f60fc90b0ef09f20f7fe9a72ab2dc1c.tar.gz
fix unused parameter warning in e1000_get_mac_type()
This fixes: external/ethtool/e1000.c:258:38: error: unused parameter 'revision_id' [-Werror,-Wunused-parameter] e1000_get_mac_type(u16 device_id, u8 revision_id) Signed-off-by: Maciej Żenczykowski <maze@google.com> Change-Id: I2469ef61996fd273cc3a2a6a7af0ae889c81b02b Signed-off-by: John W. Linville <linville@tuxdriver.com>
-rw-r--r--e1000.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/e1000.c b/e1000.c
index da057b7..91e5bc1 100644
--- a/e1000.c
+++ b/e1000.c
@@ -254,8 +254,7 @@ enum e1000_mac_type {
e1000_num_macs
};
-static enum e1000_mac_type
-e1000_get_mac_type(u16 device_id, u8 revision_id)
+static enum e1000_mac_type e1000_get_mac_type(u16 device_id)
{
enum e1000_mac_type mac_type = e1000_undefined;
@@ -369,7 +368,7 @@ int e1000_dump_regs(struct ethtool_drvinfo *info maybe_unused,
{
u32 *regs_buff = (u32 *)regs->data;
u16 hw_device_id = (u16)regs->version;
- u8 hw_revision_id = (u8)(regs->version >> 16);
+ /* u8 hw_revision_id = (u8)(regs->version >> 16); */
u8 version = (u8)(regs->version >> 24);
enum e1000_mac_type mac_type;
u32 reg;
@@ -377,7 +376,7 @@ int e1000_dump_regs(struct ethtool_drvinfo *info maybe_unused,
if (version != 1)
return -1;
- mac_type = e1000_get_mac_type(hw_device_id, hw_revision_id);
+ mac_type = e1000_get_mac_type(hw_device_id);
if(mac_type == e1000_undefined)
return -1;