diff options
| author | Thomas Falcon <tlfalcon@linux.vnet.ibm.com> | 2018-02-21 18:18:30 -0600 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-02-22 14:45:42 -0500 |
| commit | a2c0f039bbd0f9ebf375176d05b056e3f3b5c4f7 (patch) | |
| tree | eeabc314339ef97d4912345ecf1f6d0b560e84c8 | |
| parent | 83090e7d35caaabc8daa65fd698275951455bbec (diff) | |
| download | linux-a2c0f039bbd0f9ebf375176d05b056e3f3b5c4f7.tar.gz | |
ibmvnic: Fix early release of login buffer
The login buffer is released before the driver can perform
sanity checks between resources the driver requested and what
firmware will provide. Don't release the login buffer until
the sanity check is performed.
Fixes: 34f0f4e3f488 ("ibmvnic: Fix login buffer memory leaks")
Signed-off-by: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/ibm/ibmvnic.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index 1495cb99f92497..1b3cc8bb07050f 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -3760,7 +3760,6 @@ static int handle_login_rsp(union ibmvnic_crq *login_rsp_crq, dma_unmap_single(dev, adapter->login_buf_token, adapter->login_buf_sz, DMA_BIDIRECTIONAL); - release_login_buffer(adapter); dma_unmap_single(dev, adapter->login_rsp_buf_token, adapter->login_rsp_buf_sz, DMA_BIDIRECTIONAL); @@ -3791,6 +3790,7 @@ static int handle_login_rsp(union ibmvnic_crq *login_rsp_crq, ibmvnic_remove(adapter->vdev); return -EIO; } + release_login_buffer(adapter); complete(&adapter->init_done); return 0; |