diff options
| author | Yuezhang Mo <Yuezhang.Mo@sony.com> | 2024-01-12 14:48:46 +0800 |
|---|---|---|
| committer | Namjae Jeon <linkinjeon@kernel.org> | 2024-04-25 21:59:59 +0900 |
| commit | f19257997d9c31864b4cf3fcef6e2d2b9ede148d (patch) | |
| tree | a902e776fc936e79395ca5ab318659feea91c3a7 | |
| parent | d7ed5232f0f16181506373d73e711190d5e0c868 (diff) | |
| download | exfat-dev.tar.gz | |
exfat: zero the reserved fields of file and stream extension dentriesexfat-for-6.9-rc8dev
From exFAT specification, the reserved fields should initialize
to zero and should not use for any purpose.
If create a new dentry set in the UNUSED dentries, all fields
had been zeroed when allocating cluster to parent directory.
But if create a new dentry set in the DELETED dentries, the
reserved fields in file and stream extension dentries may be
non-zero. Because only the valid bit of the type field of the
dentry is cleared in exfat_remove_entries(), if the type of
dentry is different from the original(For example, a dentry that
was originally a file name dentry, then set to deleted dentry,
and then set as a file dentry), the reserved fields is non-zero.
So this commit initializes the dentry to 0 before createing file
dentry and stream extension dentry.
Signed-off-by: Yuezhang Mo <Yuezhang.Mo@sony.com>
Reviewed-by: Andy Wu <Andy.Wu@sony.com>
Reviewed-by: Aoyama Wataru <wataru.aoyama@sony.com>
Reviewed-by: Sungjong Seo <sj1557.seo@samsung.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
| -rw-r--r-- | fs/exfat/dir.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/exfat/dir.c b/fs/exfat/dir.c index 077944d3c2c025..84572e11cc05f3 100644 --- a/fs/exfat/dir.c +++ b/fs/exfat/dir.c @@ -420,6 +420,7 @@ static void exfat_set_entry_type(struct exfat_dentry *ep, unsigned int type) static void exfat_init_stream_entry(struct exfat_dentry *ep, unsigned int start_clu, unsigned long long size) { + memset(ep, 0, sizeof(*ep)); exfat_set_entry_type(ep, TYPE_STREAM); if (size == 0) ep->dentry.stream.flags = ALLOC_FAT_CHAIN; @@ -457,6 +458,7 @@ void exfat_init_dir_entry(struct exfat_entry_set_cache *es, struct exfat_dentry *ep; ep = exfat_get_dentry_cached(es, ES_IDX_FILE); + memset(ep, 0, sizeof(*ep)); exfat_set_entry_type(ep, type); exfat_set_entry_time(sbi, ts, &ep->dentry.file.create_tz, |