aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWei Yang <richard.weiyang@gmail.com>2022-11-12 23:43:08 +0000
committerAndrew Morton <akpm@linux-foundation.org>2023-01-31 16:44:08 -0800
commitab6ef70a8b0d314c2160af70b0de984664d675e0 (patch)
tree22b7ff508245eee847c17e1b340dc82b6a76d9c2
parent889a904fe34d90c4416dd403f5d3ad859180cf68 (diff)
downloadlinux-ab6ef70a8b0d314c2160af70b0de984664d675e0.tar.gz
maple_tree: should get pivots boundary by type
We should get pivots boundary by type. Fixes a potential overindexing of mt_pivots[]. Link: https://lkml.kernel.org/r/20221112234308.23823-1-richard.weiyang@gmail.com Fixes: 54a611b60590 ("Maple Tree: add new data structure") Signed-off-by: Wei Yang <richard.weiyang@gmail.com> Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
-rw-r--r--lib/maple_tree.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index b990ccea454ec4..5a976393c9aeab 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -670,12 +670,13 @@ static inline unsigned long mte_pivot(const struct maple_enode *mn,
unsigned char piv)
{
struct maple_node *node = mte_to_node(mn);
+ enum maple_type type = mte_node_type(mn);
- if (piv >= mt_pivots[piv]) {
+ if (piv >= mt_pivots[type]) {
WARN_ON(1);
return 0;
}
- switch (mte_node_type(mn)) {
+ switch (type) {
case maple_arange_64:
return node->ma64.pivot[piv];
case maple_range_64: