diff options
| author | Darrick J. Wong <djwong@kernel.org> | 2022-07-13 20:58:25 -0500 |
|---|---|---|
| committer | Eric Sandeen <sandeen@sandeen.net> | 2022-07-13 20:58:25 -0500 |
| commit | f50d3462c654acc484ab3ea68e75e8252b77e262 (patch) | |
| tree | 6b149afadc833e7131a12e52b1ed12cd8d244579 | |
| parent | 03bc653907cc4e89cbb45524063439800a722d9b (diff) | |
| download | xfsprogs-dev-f50d3462c654acc484ab3ea68e75e8252b77e262.tar.gz | |
xfs_repair: ignore empty xattr leaf blocks
As detailed in the commit:
5e572d1a xfs: empty xattr leaf header blocks are not corruption
empty xattr leaf blocks can be the benign byproduct of the system
going down during the multi-step process of adding a large xattr
to a file that has no xattrs. If we find one at attr fork offset 0,
we should clear it, but this isn't a corruption.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
| -rw-r--r-- | repair/attr_repair.c | 20 |
1 files changed, 20 insertions, 0 deletions
diff --git a/repair/attr_repair.c b/repair/attr_repair.c index 2055d96eeb..c3a6d50267 100644 --- a/repair/attr_repair.c +++ b/repair/attr_repair.c @@ -579,6 +579,26 @@ process_leaf_attr_block( firstb = mp->m_sb.sb_blocksize; stop = xfs_attr3_leaf_hdr_size(leaf); + /* + * Empty leaf blocks at offset zero can occur as a race between + * setxattr and the system going down, so we only take action if we're + * running in modify mode. See xfs_attr3_leaf_verify for details of + * how we've screwed this up many times. + */ + if (!leafhdr.count && da_bno == 0) { + if (no_modify) { + do_log( + _("would clear empty leaf attr block 0, inode %" PRIu64 "\n"), + ino); + return 0; + } + + do_warn( + _("will clear empty leaf attr block 0, inode %" PRIu64 "\n"), + ino); + return 1; + } + /* does the count look sorta valid? */ if (!leafhdr.count || leafhdr.count * sizeof(xfs_attr_leaf_entry_t) + stop > |