diff options
| author | Alex Elder <elder@linaro.org> | 2024-04-19 10:17:59 -0500 |
|---|---|---|
| committer | Paolo Abeni <pabeni@redhat.com> | 2024-04-23 13:08:08 +0200 |
| commit | 319b6d4ef08714ed593a5eb842deb249544c19e1 (patch) | |
| tree | 094bf269d7f7c05ace2c3e83ee1b86ba1da418ce | |
| parent | f2e4e9ea82f92e58ffe4aab0077445dc27a79194 (diff) | |
| download | next-queue-319b6d4ef08714ed593a5eb842deb249544c19e1.tar.gz | |
net: ipa: fix two minor ipa_cmd problems
In "ipa_cmd.h", ipa_cmd_data_valid() is declared, but that function
does not exist. So delete that declaration.
Also, for some reason ipa_cmd_init() never gets called. It isn't
really critical--it just validates that some memory offsets and a
size can be represented in some register fields, and they won't fail
with current data. Regardless, call the function in ipa_probe().
Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
| -rw-r--r-- | drivers/net/ipa/ipa_cmd.h | 8 | ||||
| -rw-r--r-- | drivers/net/ipa/ipa_main.c | 4 |
2 files changed, 4 insertions, 8 deletions
diff --git a/drivers/net/ipa/ipa_cmd.h b/drivers/net/ipa/ipa_cmd.h index 5824bb131ebab3..2077fdbade99cc 100644 --- a/drivers/net/ipa/ipa_cmd.h +++ b/drivers/net/ipa/ipa_cmd.h @@ -54,14 +54,6 @@ bool ipa_cmd_table_init_valid(struct ipa *ipa, const struct ipa_mem *mem, bool route); /** - * ipa_cmd_data_valid() - Validate command-realted configuration is valid - * @ipa: - IPA pointer - * - * Return: true if assumptions required for command are valid - */ -bool ipa_cmd_data_valid(struct ipa *ipa); - -/** * ipa_cmd_pool_init() - initialize command channel pools * @channel: AP->IPA command TX GSI channel pointer * @tre_count: Number of pool elements to allocate diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c index b13a59f27106df..6a0fec873cddf2 100644 --- a/drivers/net/ipa/ipa_main.c +++ b/drivers/net/ipa/ipa_main.c @@ -865,6 +865,10 @@ static int ipa_probe(struct platform_device *pdev) if (ret) goto err_reg_exit; + ret = ipa_cmd_init(ipa); + if (ret) + goto err_mem_exit; + ret = gsi_init(&ipa->gsi, pdev, ipa->version, data->endpoint_count, data->endpoint_data); if (ret) |