diff options
| author | Daniel Machon <daniel.machon@microchip.com> | 2023-06-06 09:19:41 +0200 |
|---|---|---|
| committer | David Ahern <dsahern@kernel.org> | 2023-06-09 15:43:55 -0600 |
| commit | 369a2df62a0d835c884f7657b8316677b5559111 (patch) | |
| tree | 3505f6aef717166f7494854e33cd066cb34b10aa | |
| parent | a245bfe1c0c6c05b22c968e82a4cb08689ec6360 (diff) | |
| download | iproute2-369a2df62a0d835c884f7657b8316677b5559111.tar.gz | |
dcb: app: modify dcb_app_table_remove_replaced() for dcb-rewr reuse
When doing a replace command, entries are checked against selector and
protocol. Rewrite requires the check to be against selector and
priority.
Adapt the existing dcb_app_table_remove_replace function for this, by
using callback functions for selector, pid and prio checks.
Signed-off-by: Daniel Machon <daniel.machon@microchip.com>
Reviewed-by: Petr Machata <me@pmachata.org>
Signed-off-by: David Ahern <dsahern@kernel.org>
| -rw-r--r-- | dcb/dcb_app.c | 18 |
1 files changed, 13 insertions, 5 deletions
diff --git a/dcb/dcb_app.c b/dcb/dcb_app.c index aa248cc40..4b309016f 100644 --- a/dcb/dcb_app.c +++ b/dcb/dcb_app.c @@ -153,8 +153,16 @@ static void dcb_app_table_remove_existing(struct dcb_app_table *a, a->n_apps = ja; } +static bool dcb_app_pid_eq(const struct dcb_app *aa, const struct dcb_app *ab) +{ + return aa->selector == ab->selector && + aa->protocol == ab->protocol; +} + static void dcb_app_table_remove_replaced(struct dcb_app_table *a, - const struct dcb_app_table *b) + const struct dcb_app_table *b, + bool (*key_eq)(const struct dcb_app *aa, + const struct dcb_app *ab)) { size_t ia, ja; size_t ib; @@ -167,13 +175,13 @@ static void dcb_app_table_remove_replaced(struct dcb_app_table *a, for (ib = 0; ib < b->n_apps; ib++) { const struct dcb_app *ab = &b->apps[ib]; - if (aa->selector == ab->selector && - aa->protocol == ab->protocol) + if (key_eq(aa, ab)) present = true; else continue; - if (aa->priority == ab->priority) { + if (aa->protocol == ab->protocol && + aa->priority == ab->priority) { found = true; break; } @@ -892,7 +900,7 @@ static int dcb_cmd_app_replace(struct dcb *dcb, const char *dev, int argc, char } /* Remove the obsolete entries. */ - dcb_app_table_remove_replaced(&orig, &tab); + dcb_app_table_remove_replaced(&orig, &tab, dcb_app_pid_eq); ret = dcb_app_add_del(dcb, dev, DCB_CMD_IEEE_DEL, &orig, NULL); if (ret != 0) { fprintf(stderr, "Could not remove replaced APP entries\n"); |