diff options
| author | Bastian Germann <bage@linutronix.de> | 2021-11-09 18:21:25 +0100 |
|---|---|---|
| committer | Michal Kubecek <mkubecek@suse.cz> | 2021-11-09 20:55:19 +0100 |
| commit | fd7db6457916e89795cdc3d2a0603103578d9419 (patch) | |
| tree | fc6bd99a444a1abc68851d6f46ba42bbdd963ff2 | |
| parent | 88892ece6357ddb74fe52a3209c11b9867d4f7b1 (diff) | |
| download | ethtool-fd7db6457916e89795cdc3d2a0603103578d9419.tar.gz | |
netlink: settings: Correct duplicate condition
tb's fields ETHTOOL_A_LINKINFO_TP_MDIX and ETHTOOL_A_LINKINFO_TP_MDIX_CTRL
are used in this case. The condition is duplicate for the former. Fix that.
Fixes: 10cc3ea337d1 ("netlink: partial netlink handler for gset (no option)")
Signed-off-by: Bastian Germann <bage@linutronix.de>
Acked-by: Michal Kubecek <mkubecek@suse.cz>
| -rw-r--r-- | netlink/settings.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/netlink/settings.c b/netlink/settings.c index 6d10a07..c4f5d61 100644 --- a/netlink/settings.c +++ b/netlink/settings.c @@ -560,7 +560,7 @@ int linkinfo_reply_cb(const struct nlmsghdr *nlhdr, void *data) print_enum(names_transceiver, ARRAY_SIZE(names_transceiver), val, "Transceiver"); } - if (tb[ETHTOOL_A_LINKINFO_TP_MDIX] && tb[ETHTOOL_A_LINKINFO_TP_MDIX] && + if (tb[ETHTOOL_A_LINKINFO_TP_MDIX] && tb[ETHTOOL_A_LINKINFO_TP_MDIX_CTRL] && port == PORT_TP) { uint8_t mdix = mnl_attr_get_u8(tb[ETHTOOL_A_LINKINFO_TP_MDIX]); uint8_t mdix_ctrl = |