aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJulia Cartwright <julia@ni.com>2017-02-16 16:57:21 -0600
committerSteven Rostedt (VMware) <rostedt@goodmis.org>2017-04-26 10:49:42 -0400
commit743bb45e49ac30884ec92a7ded21181bea74f822 (patch)
treea3a375ea3c0462f3531aa926934497a5ce015d59
parent39f166e86bdccb33618fd3c28672c92c6d0267ca (diff)
downloadtrace-cmd-743bb45e49ac30884ec92a7ded21181bea74f822.tar.gz
trace-cmd: Fixup more bogus symbol resolutions
Commit ce1cbc51c ("trace-cmd: Leave out absolute addresses to fix bogus symbol resolutions") fixed up bogus symbol resolution for 'A' type symbols used on x86_64 for percpu offsets. However, this check did not cover per-cpu variables used in modules, which are generated as 'local' absolute symbols, and therefore appear as 'a' in /proc/kallsyms. Fix this. Link: http://lkml.kernel.org/r/20170216225721.13087-1-julia@ni.com Cc: Jan Kiszka <jan.kiszka@siemens.com> Signed-off-by: Julia Cartwright <julia@ni.com> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-rw-r--r--trace-util.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/trace-util.c b/trace-util.c
index 4073c790..fbf8cea2 100644
--- a/trace-util.c
+++ b/trace-util.c
@@ -459,7 +459,7 @@ void tracecmd_parse_proc_kallsyms(struct pevent *pevent,
* - arm arch that adds a lot of bogus '$a' functions
* - x86-64 that reports per-cpu variable offsets as absolute
*/
- if (func[0] != '$' && ch != 'A')
+ if (func[0] != '$' && ch != 'A' && ch != 'a')
pevent_register_function(pevent, func, addr, mod);
free(func);
free(mod);