diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2022-07-07 17:54:45 +0300 |
|---|---|---|
| committer | Jonathan Cameron <Jonathan.Cameron@huawei.com> | 2022-07-16 18:43:59 +0100 |
| commit | 648fbbc7289b7f48122d887b79a2488fc318205a (patch) | |
| tree | 5e6b90e08e1369a3fbcefc4c7efd08c18a86056a | |
| parent | e0e1824bf69e9a342eb4854cf10ce2ba4c840e36 (diff) | |
| download | iio-fixes-togreg-post-5.20-rc1.tar.gz | |
iio: adc: max1027: unlock on error path in max1027_read_single_value()fixes-togreg-post-5.20-rc1
If max1027_wait_eoc() fails then call iio_device_release_direct_mode()
before returning.
Fixes: a0e831653ef9 ("iio: adc: max1027: Introduce an end of conversion helper")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YsbztVuAXnau2cIZ@kili
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
| -rw-r--r-- | drivers/iio/adc/max1027.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/iio/adc/max1027.c b/drivers/iio/adc/max1027.c index b725d012625c1..136fcf753837c 100644 --- a/drivers/iio/adc/max1027.c +++ b/drivers/iio/adc/max1027.c @@ -349,8 +349,7 @@ static int max1027_read_single_value(struct iio_dev *indio_dev, if (ret < 0) { dev_err(&indio_dev->dev, "Failed to configure conversion register\n"); - iio_device_release_direct_mode(indio_dev); - return ret; + goto release; } /* @@ -360,11 +359,12 @@ static int max1027_read_single_value(struct iio_dev *indio_dev, */ ret = max1027_wait_eoc(indio_dev); if (ret) - return ret; + goto release; /* Read result */ ret = spi_read(st->spi, st->buffer, (chan->type == IIO_TEMP) ? 4 : 2); +release: iio_device_release_direct_mode(indio_dev); if (ret < 0) |