diff options
| author | Alexey Kodanev <aleksei.kodanev@bell-sw.com> | 2022-12-27 16:33:06 +0300 |
|---|---|---|
| committer | Kalle Valo <kvalo@kernel.org> | 2023-01-16 18:22:24 +0200 |
| commit | 1e346cbb096a5351a637ec1992beffbf330547f0 (patch) | |
| tree | 23bef6067ea602d2368f8d4021736643a4385ffe | |
| parent | cb689109d9d7e5668f23aafed49a02c55f0aaa6d (diff) | |
| download | iwlwifi-next-1e346cbb096a5351a637ec1992beffbf330547f0.tar.gz | |
wifi: orinoco: check return value of hermes_write_wordrec()
There is currently no return check for writing an authentication
type (HERMES_AUTH_SHARED_KEY or HERMES_AUTH_OPEN). It looks like
it was accidentally skipped.
This patch adds a return check similar to the other checks in
__orinoco_hw_setup_enc() for hermes_write_wordrec().
Detected using the static analysis tool - Svace.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Alexey Kodanev <aleksei.kodanev@bell-sw.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20221227133306.201356-1-aleksei.kodanev@bell-sw.com
| -rw-r--r-- | drivers/net/wireless/intersil/orinoco/hw.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/wireless/intersil/orinoco/hw.c b/drivers/net/wireless/intersil/orinoco/hw.c index 0aea35c9c11c7..4fcca08e50de2 100644 --- a/drivers/net/wireless/intersil/orinoco/hw.c +++ b/drivers/net/wireless/intersil/orinoco/hw.c @@ -931,6 +931,8 @@ int __orinoco_hw_setup_enc(struct orinoco_private *priv) err = hermes_write_wordrec(hw, USER_BAP, HERMES_RID_CNFAUTHENTICATION_AGERE, auth_flag); + if (err) + return err; } err = hermes_write_wordrec(hw, USER_BAP, HERMES_RID_CNFWEPENABLED_AGERE, |