diff options
| author | Arun Ramadoss <arun.ramadoss@microchip.com> | 2022-12-13 15:44:40 +0530 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2022-12-19 17:18:48 -0800 |
| commit | 62e027fb0e5293d95e8d36655757ef4687c8795d (patch) | |
| tree | b6b26709a016d183969022bb5df34ca070db460e | |
| parent | 2856a62762c8409e360d4fd452194c8e57ba1058 (diff) | |
| download | pci-62e027fb0e5293d95e8d36655757ef4687c8795d.tar.gz | |
net: dsa: microchip: remove IRQF_TRIGGER_FALLING in request_threaded_irq
KSZ swithes used interrupts for detecting the phy link up and down.
During registering the interrupt handler, it used IRQF_TRIGGER_FALLING
flag. But this flag has to be retrieved from device tree instead of hard
coding in the driver, so removing the flag.
Fixes: ff319a644829 ("net: dsa: microchip: move interrupt handling logic from lan937x to ksz_common")
Reported-by: Christian Eggers <ceggers@arri.de>
Signed-off-by: Arun Ramadoss <arun.ramadoss@microchip.com>
Link: https://lore.kernel.org/r/20221213101440.24667-1-arun.ramadoss@microchip.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | drivers/net/dsa/microchip/ksz_common.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c index 423f944cc34c36..9b20c2ee6d62a3 100644 --- a/drivers/net/dsa/microchip/ksz_common.c +++ b/drivers/net/dsa/microchip/ksz_common.c @@ -1996,8 +1996,7 @@ static int ksz_irq_common_setup(struct ksz_device *dev, struct ksz_irq *kirq) irq_create_mapping(kirq->domain, n); ret = request_threaded_irq(kirq->irq_num, NULL, ksz_irq_thread_fn, - IRQF_ONESHOT | IRQF_TRIGGER_FALLING, - kirq->name, kirq); + IRQF_ONESHOT, kirq->name, kirq); if (ret) goto out; |