diff options
| author | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2020-05-31 11:55:21 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2020-06-11 19:04:44 +0200 |
| commit | f2fb029b3790e1f374e93fc6d0ca1e6239e44543 (patch) | |
| tree | 8e58cb19df59dacf931b4a3fdc12749d467f2390 | |
| parent | 495eef11f79d176ba28435ff78adbcb77e5326c8 (diff) | |
| download | usb-f2fb029b3790e1f374e93fc6d0ca1e6239e44543.tar.gz | |
media: atomisp: improve IRQ handling debug messages
When an IRQ is not handled, it is nice to know what's the
reason.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
| -rw-r--r-- | drivers/staging/media/atomisp/pci/atomisp_cmd.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c index c5a602fa6ce45e..8d0a437f507c72 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c @@ -566,7 +566,7 @@ irqreturn_t atomisp_isr(int irq, void *dev) if (irq_infos & IA_CSS_IRQ_INFO_CSS_RECEIVER_SOF) { dev_dbg_ratelimited(isp->dev, - "irq:0x%x (IA_CSS_IRQ_INFO_CSS_RECEIVER_SOF)\n", + "irq:0x%x (SOF)\n", irq_infos); irq_infos &= ~IA_CSS_IRQ_INFO_CSS_RECEIVER_SOF; } @@ -591,14 +591,14 @@ irqreturn_t atomisp_isr(int irq, void *dev) /* EOF Event does not have the css_pipe returned */ asd = __get_asd_from_port(isp, eof_event.event.port); if (!asd) { - dev_err(isp->dev, "%s:no subdev.event:%d", + dev_err(isp->dev, "%s: ISYS event, but no subdev.event:%d", __func__, eof_event.event.type); continue; } atomisp_eof_event(asd, eof_event.event.exp_id); dev_dbg_ratelimited(isp->dev, - "%s EOF exp_id %d, asd %d\n", + "%s ISYS event: EOF exp_id %d, asd %d\n", __func__, eof_event.event.exp_id, asd->index); } @@ -610,7 +610,7 @@ irqreturn_t atomisp_isr(int irq, void *dev) spin_unlock_irqrestore(&isp->lock, flags); - dev_dbg_ratelimited(isp->dev, "irq:0x%x\n", irq_infos); + dev_dbg_ratelimited(isp->dev, "irq:0x%x (unhandled)\n", irq_infos); return IRQ_WAKE_THREAD; @@ -618,7 +618,8 @@ out_nowake: spin_unlock_irqrestore(&isp->lock, flags); if (irq_infos) - dev_dbg_ratelimited(isp->dev, "irq:0x%x\n", irq_infos); + dev_dbg_ratelimited(isp->dev, "irq:0x%x (ignored, as not streaming anymore)\n", + irq_infos); return IRQ_HANDLED; } |