diff options
Diffstat (limited to 'staging-gigaset-fix-illegal-free-on-probe-errors.patch')
| -rw-r--r-- | staging-gigaset-fix-illegal-free-on-probe-errors.patch | 47 |
1 files changed, 0 insertions, 47 deletions
diff --git a/staging-gigaset-fix-illegal-free-on-probe-errors.patch b/staging-gigaset-fix-illegal-free-on-probe-errors.patch deleted file mode 100644 index f9e9981..0000000 --- a/staging-gigaset-fix-illegal-free-on-probe-errors.patch +++ /dev/null @@ -1,47 +0,0 @@ -From 84f60ca7b326ed8c08582417493982fe2573a9ad Mon Sep 17 00:00:00 2001 -From: Johan Hovold <johan@kernel.org> -Date: Mon, 2 Dec 2019 09:56:09 +0100 -Subject: staging: gigaset: fix illegal free on probe errors - -From: Johan Hovold <johan@kernel.org> - -commit 84f60ca7b326ed8c08582417493982fe2573a9ad upstream. - -The driver failed to initialise its receive-buffer pointer, something -which could lead to an illegal free on late probe errors. - -Fix this by making sure to clear all driver data at allocation. - -Fixes: 2032e2c2309d ("usb_gigaset: code cleanup") -Cc: stable <stable@vger.kernel.org> # 2.6.33 -Cc: Tilman Schmidt <tilman@imap.cc> -Signed-off-by: Johan Hovold <johan@kernel.org> -Link: https://lore.kernel.org/r/20191202085610.12719-3-johan@kernel.org -Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> - ---- - drivers/isdn/gigaset/usb-gigaset.c | 6 +----- - 1 file changed, 1 insertion(+), 5 deletions(-) - ---- a/drivers/isdn/gigaset/usb-gigaset.c -+++ b/drivers/isdn/gigaset/usb-gigaset.c -@@ -579,8 +579,7 @@ static int gigaset_initcshw(struct cards - { - struct usb_cardstate *ucs; - -- cs->hw.usb = ucs = -- kmalloc(sizeof(struct usb_cardstate), GFP_KERNEL); -+ cs->hw.usb = ucs = kzalloc(sizeof(struct usb_cardstate), GFP_KERNEL); - if (!ucs) { - pr_err("out of memory\n"); - return -ENOMEM; -@@ -592,9 +591,6 @@ static int gigaset_initcshw(struct cards - ucs->bchars[3] = 0; - ucs->bchars[4] = 0x11; - ucs->bchars[5] = 0x13; -- ucs->bulk_out_buffer = NULL; -- ucs->bulk_out_urb = NULL; -- ucs->read_urb = NULL; - tasklet_init(&cs->write_tasklet, - gigaset_modem_fill, (unsigned long) cs); - |