aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGeliang Tang <tanggeliang@kylinos.cn>2024-04-16 13:30:42 +0800
committerGeliang Tang <tanggeliang@kylinos.cn>2024-04-22 10:55:28 +0800
commitf6b819429e96ef2e98d8ddf19a788529996e9f8d (patch)
tree7cc9bb295eac6fbe2045b64f0ae7994051db1208
parent318f242707f2818895751b3a15537b54b2286af4 (diff)
downloadmptcp_net-next-f6b819429e96ef2e98d8ddf19a788529996e9f8d.tar.gz
selftests/bpf: Drop get_port in test_tcp_check_syncookie
Function get_port() in test_tcp_check_syncookie_user.c becomes useless now, drop it and all struct sockaddr variables in main() too. Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
-rw-r--r--tools/testing/selftests/bpf/test_tcp_check_syncookie_user.c21
1 files changed, 3 insertions, 18 deletions
diff --git a/tools/testing/selftests/bpf/test_tcp_check_syncookie_user.c b/tools/testing/selftests/bpf/test_tcp_check_syncookie_user.c
index aa1774029fa6ec..094b3b01926ae7 100644
--- a/tools/testing/selftests/bpf/test_tcp_check_syncookie_user.c
+++ b/tools/testing/selftests/bpf/test_tcp_check_syncookie_user.c
@@ -139,21 +139,6 @@ out:
return ret;
}
-static bool get_port(int server_fd, in_port_t *port)
-{
- struct sockaddr_in addr;
- socklen_t len = sizeof(addr);
-
- if (getsockname(server_fd, (struct sockaddr *)&addr, &len)) {
- log_err("Failed to get server addr");
- return false;
- }
-
- /* sin_port and sin6_port are located at the same offset. */
- *port = addr.sin_port;
- return true;
-}
-
static int setsockopt_mode(int fd, const void *optval, socklen_t optlen)
{
return setsockopt(fd, IPPROTO_IPV6, IPV6_V6ONLY, optval, optlen);
@@ -211,19 +196,19 @@ int main(int argc, char **argv)
server = start_server_addr(SOCK_STREAM, (struct sockaddr_storage *)&addr4,
sizeof(addr4), NULL);
- if (server == -1 || !get_port(server, &addr4.sin_port))
+ if (server == -1)
goto err;
mode = true;
server_v6 = start_server_addr(SOCK_STREAM, (struct sockaddr_storage *)&addr6,
sizeof(addr6), &opts);
- if (server_v6 == -1 || !get_port(server_v6, &addr6.sin6_port))
+ if (server_v6 == -1)
goto err;
mode = false;
server_dual = start_server_addr(SOCK_STREAM, (struct sockaddr_storage *)&addr6dual,
sizeof(addr6dual), &opts);
- if (server_dual == -1 || !get_port(server_dual, &addr4dual.sin_port))
+ if (server_dual == -1)
goto err;
if (run_test(server, results, xdp))