diff options
| author | Geliang Tang <geliang.tang@suse.com> | 2023-08-16 14:33:47 +0800 |
|---|---|---|
| committer | Geliang Tang <tanggeliang@kylinos.cn> | 2024-04-22 10:56:53 +0800 |
| commit | 4056723905258689031604a40375240a6f07c47e (patch) | |
| tree | a9d0db1c7fb7a3595ab72a13d7ea238c87acd28c | |
| parent | ad42bbf663a4d387729256abec985f69107ed27c (diff) | |
| download | mptcp_net-next-4056723905258689031604a40375240a6f07c47e.tar.gz | |
selftests: mptcp: join: simplify deny_join_id0_tests
The six join id0 tests can be divided into three groups in sequence,
with two tests in each one. Both tests in one group are similar, only
different namespaces used. So a for-loop can be used to simplify these
tests.
Signed-off-by: Geliang Tang <geliang.tang@suse.com>
| -rwxr-xr-x | tools/testing/selftests/net/mptcp/mptcp_join.sh | 33 |
1 files changed, 13 insertions, 20 deletions
diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh index a747b9dcded8f1..b915845eb27755 100755 --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh @@ -2896,27 +2896,20 @@ deny_join_id0_tests() chk_join_nr 0 0 0 fi - # signal address allow join id0 ns1 + # signal address allow join id0 ns1/2 # ADD_ADDRs are not affected by allow_join_id0 value. - if reset_with_allow_join_id0 "signal address allow join id0 ns1" 1 0; then - pm_nl_set_limits $ns1 1 1 - pm_nl_set_limits $ns2 1 1 - pm_nl_add_endpoint $ns1 10.0.2.1 flags signal - run_tests $ns1 $ns2 10.0.1.1 - chk_join_nr 1 1 1 - chk_add_nr 1 1 - fi - - # signal address allow join id0 ns2 - # ADD_ADDRs are not affected by allow_join_id0 value. - if reset_with_allow_join_id0 "signal address allow join id0 ns2" 0 1; then - pm_nl_set_limits $ns1 1 1 - pm_nl_set_limits $ns2 1 1 - pm_nl_add_endpoint $ns1 10.0.2.1 flags signal - run_tests $ns1 $ns2 10.0.1.1 - chk_join_nr 1 1 1 - chk_add_nr 1 1 - fi + local ns enable="1 0" + for ns in "ns1" "ns2"; do + [ $ns == "ns2" ] && enable="0 1" + if reset_with_allow_join_id0 "signal address allow join id0 $ns" $enable; then + pm_nl_set_limits $ns1 1 1 + pm_nl_set_limits $ns2 1 1 + pm_nl_add_endpoint $ns1 10.0.2.1 flags signal + run_tests $ns1 $ns2 10.0.1.1 + chk_join_nr 1 1 1 + chk_add_nr 1 1 + fi + done # subflow and address allow join id0 ns1 if reset_with_allow_join_id0 "subflow and address allow join id0 1" 1 0; then |