diff options
| author | Amir Goldstein <amir73il@gmail.com> | 2023-08-15 11:28:35 +0300 |
|---|---|---|
| committer | Zorro Lang <zlang@kernel.org> | 2023-08-19 02:48:06 +0800 |
| commit | 9caf3ee07d0d0071e70f5bde28e6cd32bbc0e266 (patch) | |
| tree | be6370bd2ff553866eabe10016718131112319a7 | |
| parent | 6d63f23987a629b4f7dd6e57e5b67ba37a3b742e (diff) | |
| download | xfstests-dev-9caf3ee07d0d0071e70f5bde28e6cd32bbc0e266.tar.gz | |
generic/{175,297,298}: fix use of uninitialized var
The truncate command in those tests use an uninitialized variable i.
in kdevops, i must contain some leftover, so we get errors like:
/data/fstests-install/xfstests/tests/generic/298: line 45: /dev/loop12):
syntax error: operand expected (error token is "/dev/loop12)")
Apparently, noone including the author of the tests knows why this
truncate command is in the test, so remove the wrong truncate command.
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Zorro Lang <zlang@redhat.com>
Signed-off-by: Zorro Lang <zlang@kernel.org>
| -rwxr-xr-x | tests/generic/175 | 1 | ||||
| -rwxr-xr-x | tests/generic/297 | 1 | ||||
| -rwxr-xr-x | tests/generic/298 | 1 |
3 files changed, 0 insertions, 3 deletions
diff --git a/tests/generic/175 b/tests/generic/175 index 07af219920..f827beb67f 100755 --- a/tests/generic/175 +++ b/tests/generic/175 @@ -33,7 +33,6 @@ _pwrite_byte 0x61 0 $blksz "$testdir/file1" >> "$seqres.full" fnr=19 echo "Create extents" -truncate -s $(( (2 ** i) * blksz)) "$testdir/file1" for i in $(seq 0 $fnr); do echo " ++ Reflink size $i, $((2 ** i)) blocks" >> "$seqres.full" n=$(( (2 ** i) * blksz)) diff --git a/tests/generic/297 b/tests/generic/297 index 6bdc3e1c7a..54c2ac2142 100755 --- a/tests/generic/297 +++ b/tests/generic/297 @@ -42,7 +42,6 @@ _pwrite_byte 0x61 0 $blksz $testdir/file1 >> $seqres.full fnr=26 # 2^26 reflink extents should be enough to find a slow op? timeout=8 # guarantee a good long run... echo "Find a reflink size that takes a long time" -truncate -s $(( (2 ** i) * blksz)) $testdir/file1 for i in $(seq 0 $fnr); do echo " ++ Reflink size $i, $((2 ** i)) blocks" >> $seqres.full n=$(( (2 ** i) * blksz)) diff --git a/tests/generic/298 b/tests/generic/298 index 95d4c02bce..115a9bf74e 100755 --- a/tests/generic/298 +++ b/tests/generic/298 @@ -42,7 +42,6 @@ _pwrite_byte 0x61 0 $blksz $testdir/file1 >> $seqres.full fnr=26 # 2^26 reflink extents should be enough to find a slow op? timeout=8 # guarantee a good long run... echo "Find a reflink size that takes a long time" -truncate -s $(( (2 ** i) * blksz)) $testdir/file1 for i in $(seq 0 $fnr); do echo " ++ Reflink size $i, $((2 ** i)) blocks" >> $seqres.full n=$(( (2 ** i) * blksz)) |