diff options
| author | Colin Ian King <colin.king@canonical.com> | 2018-02-26 22:43:18 -0600 |
|---|---|---|
| committer | Eric Sandeen <sandeen@redhat.com> | 2018-02-26 22:43:18 -0600 |
| commit | dfcfc5f1aac7eb29d94eca4d45d9254eb96499a8 (patch) | |
| tree | f30d99336d4fbda8689b0c6749f877c699d29bbe | |
| parent | d7e71605e73f5c05ac029046d56781b675311592 (diff) | |
| download | xfsprogs-dev-dfcfc5f1aac7eb29d94eca4d45d9254eb96499a8.tar.gz | |
xfs: fix check on struct_version for versions 4 or greater
Source kernel commit: a8789a5ae28f69d7f3791a0e74f8c44222f3108b
It appears that the check for versions 4 or more is incorrect and is
off-by-one. Fix this.
Detected by CoverityScan, CID#1463775 ("Logically dead code")
Fixes: ac503a4cc9e8 ("xfs: refactor the geometry structure filling function")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
| -rw-r--r-- | libxfs/xfs_sb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libxfs/xfs_sb.c b/libxfs/xfs_sb.c index 1aeb6b034e..57c88d220e 100644 --- a/libxfs/xfs_sb.c +++ b/libxfs/xfs_sb.c @@ -933,7 +933,7 @@ xfs_fs_geometry( geo->rtsectsize = sbp->sb_blocksize; geo->dirblocksize = xfs_dir2_dirblock_bytes(sbp); - if (struct_version < 3) + if (struct_version < 4) return 0; if (xfs_sb_version_haslogv2(sbp)) |