aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFedor Pchelkin <pchelkin@ispras.ru>2023-12-20 12:53:15 +0300
committerInki Dae <inki.dae@samsung.com>2024-01-22 12:24:55 +0900
commit4050957c7c2c14aa795dbf423b4180d5ac04e113 (patch)
tree0c26bdf05b0578d7bcf7691e2955c13792dacc36
parent960b537e91725bcb17dd1b19e48950e62d134078 (diff)
downloaddrm-exynos-fixes/exynos-drm-fixes-for-v6.8-rc2.tar.gz
drm/exynos: gsc: minor fix for loop iteration in gsc_runtime_resumeexynos-drm-fixes-for-v6.8-rc2fixes/exynos-drm-fixes-for-v6.8-rc2
Do not forget to call clk_disable_unprepare() on the first element of ctx->clocks array. Found by Linux Verification Center (linuxtesting.org). Fixes: 8b7d3ec83aba ("drm/exynos: gsc: Convert driver to IPP v2 core API") Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Inki Dae <inki.dae@samsung.com>
-rw-r--r--drivers/gpu/drm/exynos/exynos_drm_gsc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c b/drivers/gpu/drm/exynos/exynos_drm_gsc.c
index 34cdabc30b4f5..5302bebbe38c9 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_gsc.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_gsc.c
@@ -1342,7 +1342,7 @@ static int __maybe_unused gsc_runtime_resume(struct device *dev)
for (i = 0; i < ctx->num_clocks; i++) {
ret = clk_prepare_enable(ctx->clocks[i]);
if (ret) {
- while (--i > 0)
+ while (--i >= 0)
clk_disable_unprepare(ctx->clocks[i]);
return ret;
}